This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Update TensorFlow-specific Swift formatters. #1559
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `TensorXD` and `ArrayXD` formatters. Those types have been deleted.
Collaborator
Author
|
Manually tested with a full Swift toolchain on macOS. $ swift
Welcome to Swift version 5.0-dev (LLVM 082dec2e22, Swift 6bf3d4b528).
Type :help for assistance.
1> import TensorFlow
2> Tensor(1)
$R0: TensorFlow.Tensor<Double> = 1.0Todo: add a test to |
marcrasi
approved these changes
May 10, 2019
dcci
reviewed
Jun 21, 2019
Contributor
dcci
left a comment
dcci
left a comment
There was a problem hiding this comment.
FWIW, you can also add a test in lit/SwiftREPL [if it's easier for you]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
TensorXDandArrayXDformatters.Those types have been deleted.