Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump approvals from 6.2.1 to 7.1.0 #6

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 20, 2024

Bumps approvals from 6.2.1 to 7.1.0.

Release notes

Sourced from approvals's releases.

Support for VS Codium

Added a reporter for vs codium

Thanks to @​stevendkwtz

Typescript

There should be no visible changes from this release ¯_(ツ)_/¯ But all of the source files have been upgraded to typescript.

Normally I would set this as a patch release, but I making it a major version as I am concerned about changes to have javascript and typescript handle exports.

I have had to use the following a bit

Imports

var a = require("a")

import {a} from "a"
or 
import * as a from "a"
Fix JestReporter importing full class instead of type
For the future, we have set "importsNotUsedAsValues" to "error" to prevent future recurrences.
This helps other packages that have this value set not error-out because they are using Approvals.
fix version number in npm package
Fixes #150
the 'v' in v6.2.3 caused trouble with npm
Minor bug with Angular + Jest
Added check when running JestApprovals in angular

Commits
  • 62c8cab - F added CodiumReporter
  • 7e8bc0d - r better typescript in GenericDiffReporterBase.ts
  • 8873b35 - r better typescript in vscodeReporter.ts
  • 430e507 - r better typescript in opendiffReporter.ts
  • 0b00b64 - r better typescript in visualstudioReporter.ts & GenericDiffReporterBase.ts
  • 488bd0a - r better typescript in visualstudioReporter.ts
  • df08606 - r better typescript
  • 8ee1552 - r better names and typescript
  • 2ece6ab - r revert to require until approvals export is upgraded
  • 7c1feb9 - r discard type error
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [approvals](https://github.com/approvals/Approvals.NodeJS) from 6.2.1 to 7.1.0.
- [Release notes](https://github.com/approvals/Approvals.NodeJS/releases)
- [Commits](approvals/Approvals.NodeJS@v6.2.1...v7.1.0)

---
updated-dependencies:
- dependency-name: approvals
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 20, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 20, 2024

Looks like approvals is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 20, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/approvals-7.1.0 branch May 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants