fix: move OAuth2 expiry field next to scopes - #42191
Conversation
|
Thanks for contributing to Appsmith! Credential-free formatting, lint, type, and unit checks will run after GitHub's workflow approval. An Appsmith maintainer will start privileged integration tests or a deploy preview when needed. No action is required from you while this PR has the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe OAuth2 ChangesOAuth2 field placement
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The Authorization Code expiration field is now displayed directly after Scope(s), while Client Credentials behavior remains unchanged. The change is ready to merge. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Moves the Authorization expires in (seconds) field directly after Scope(s) in the authenticated API OAuth2 form, so related authentication settings stay adjacent and easier to discover.
The field remains limited to the Authorization Code grant type, preserving the existing behavior for Client Credentials.
Fixes #31059
Testing
tsc --noEmit --pretty falsescopeString→expiresIn→isAuthorizationHeaderand a singleexpiresInfieldCommunication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit