Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): check if metadata is not nil #8593

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nikpivkin
Copy link
Contributor

Description

This PR fixes a potential panic when falling back to embedded checks due to missing annotations.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin force-pushed the checks-fallback-annot branch from 16b98e6 to 6666881 Compare March 21, 2025 11:05
@nikpivkin
Copy link
Contributor Author

@simar7 Hmm, this is the second time today that I've run into problems in CI. Locally, the new test passes successfully, but in Github Actions the test fails with an error: could not find schema “fooschema”, even though the Rego check in the test doesn't even use schemas.

Signed-off-by: nikpivkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant