fix(scraper): fall back to browser on tls certificate errors#378
Merged
fix(scraper): fall back to browser on tls certificate errors#378
Conversation
Treat TLS certificate validation failures as non-retryable and fall back to the browser fetcher when the HTTP client cannot build a trust chain. This keeps broken third-party certificate chains from failing after repeated backoff attempts while preserving stricter transport checks by default. Refs #368
There was a problem hiding this comment.
Pull request overview
This PR improves scraper resilience to TLS certificate validation failures by classifying them as non-retryable errors and routing affected requests through the browser-based fetcher as a fallback.
Changes:
- Introduces
TlsCertificateErrorto represent certificate validation failures as non-retryableScraperErrors. - Updates
HttpFetcherto detect common TLS certificate error codes, avoid retries, and throwTlsCertificateError. - Updates
AutoDetectFetcherto fall back toBrowserFetcheronTlsCertificateError, with regression tests for both behaviors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/errors.ts | Adds TlsCertificateError as a dedicated non-retryable scraper error type. |
| src/scraper/fetcher/HttpFetcher.ts | Detects TLS certificate error codes and throws TlsCertificateError without retrying. |
| src/scraper/fetcher/HttpFetcher.test.ts | Adds a regression test ensuring TLS certificate failures do not trigger retries. |
| src/scraper/fetcher/AutoDetectFetcher.ts | Falls back to BrowserFetcher when HttpFetcher throws TlsCertificateError. |
| src/scraper/fetcher/AutoDetectFetcher.test.ts | Adds tests for TLS fallback, challenge fallback, and non-fallback error behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #368.
Follow-up security configuration work is tracked separately in #376.