Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ Feature: Updated UI/UX for "Upload new document" modal #1210

Closed
1 task done
tenokami opened this issue Oct 3, 2024 · 10 comments Β· Fixed by #1274
Closed
1 task done

πŸš€ Feature: Updated UI/UX for "Upload new document" modal #1210

tenokami opened this issue Oct 3, 2024 · 10 comments Β· Fixed by #1274
Assignees
Labels
enhancement New feature or request frontend hacktoberfest help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@tenokami
Copy link
Collaborator

tenokami commented Oct 3, 2024

πŸ”– Feature description

https://www.figma.com/design/OXLtrl1EAy885to6S69554/DocsGPT?node-id=0-1&t=N50TV6CgjXioM0rQ-1

image
image

🎀 Why is this feature needed ?

Better UI/UX

✌️ How do you aim to achieve this?

Better UI/UX

πŸ”„οΈ Additional Information

It might be optimal to work on this issue after #1201 is completed because they share some similarities that can be reused.

πŸ‘€ Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@tenokami tenokami added enhancement New feature or request help wanted Extra attention is needed javascript Pull requests that update Javascript code hacktoberfest frontend labels Oct 3, 2024
@tenokami tenokami changed the title πŸš€ Feature: Updated UI/UX for "Uplad new document" modal πŸš€ Feature: Updated UI/UX for "Upload new document" modal Oct 3, 2024
@rohittcodes
Copy link
Contributor

Hey @tenokami, I would like to work on it.

@ovindu-a
Copy link
Contributor

ovindu-a commented Oct 4, 2024

@tenokami hi, I would like to work on this UI/UX feature

@shelar1423
Copy link
Collaborator

@rohittcodes assigned it to you !

@tenokami
Copy link
Collaborator Author

tenokami commented Oct 4, 2024

@ovindu-a Thank you! Please make sure that training loader is consistent with #1201

@tenokami
Copy link
Collaborator Author

tenokami commented Oct 6, 2024

@rohittcodes I've added a dark theme if you could please develop it too.

image

@rohittcodes
Copy link
Contributor

yeah sure!

@ovindu-a
Copy link
Contributor

ovindu-a commented Oct 6, 2024

@ovindu-a Thank you! Please make sure that training loader is consistent with #1201

@tenokami looks like @rohittcodes is working on it already right. Is there something else I could do?

@tenokami
Copy link
Collaborator Author

tenokami commented Oct 6, 2024

@ovindu-a Thank you! Please make sure that training loader is consistent with #1201

@tenokami looks like @rohittcodes is working on it already right. Is there something else I could do?

New issues will be added soon

@rohittcodes
Copy link
Contributor

hey @tenokami! I'm almost done with the UI can you've a look into it. and there is some issue with the worker from my side while training, so the training percentage is stuck at 0% only. But I've updated the styles for it on 100% too. And, I've added a prop named isOnboarding to the <Upload /> component, which will work with the issue #1201, and it will take some condition based styling there.

Can I submit the PR or is it necessary to try the training too. I've not played with any functions related to fetching (training/upload). So i guess it won't have issues?

docsgpt.mp4

@dartpain
Copy link
Contributor

dartpain commented Oct 8, 2024

Yeah please submit the PR, we will test out some of the potential issues if they exist with upload itself.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend hacktoberfest help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants