Skip to content

Refactor listeners to use List interface #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viola-Siemens wants to merge 1 commit into
base: 1.20
Choose a base branch
from
Open

Refactor listeners to use List interface #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions common/src/main/java/dev/architectury/event/EventFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public static <T> Event<EventActor<T>> attachToForgeEventActorCancellable(Event<
private static class EventImpl<T> implements Event<T> {
private final Function<List<T>, T> function;
private T invoker = null;
private ArrayList<T> listeners;
private List<T> listeners;

public EventImpl(Function<List<T>, T> function) {
this.function = function;
Expand All @@ -221,7 +221,9 @@ public void register(T listener) {
@Override
public void unregister(T listener) {
listeners.remove(listener);
listeners.trimToSize();
if(listeners instanceof ArrayList<?> arrayListListeners) {
arrayListListeners.trimToSize();
}
invoker = null;
}

Expand All @@ -233,7 +235,9 @@ public boolean isRegistered(T listener) {
@Override
public void clearListeners() {
listeners.clear();
listeners.trimToSize();
if(listeners instanceof ArrayList<?> arrayListListeners) {
arrayListListeners.trimToSize();
}
invoker = null;
}

Expand Down