Replace encryption password #2011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encryption password should not be copied to the target system log. Passing it to `Journald` in plain text should be OK on the installation system.
|
@abulvenz the log function is a generic function to log text. Adding a custom filter for strings in there isn't the right way to go, but we should rather track down which caller of this function is actually trying to log the encryption password and prevent it there |
|
In addition, this doesn't really solve the issue linked as the problem there is the credentials configuration file NOT any logging of passwords, which we're not actually doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
The encryption password should not be copied to the target system log. Passing it to
Journaldin plain text should be OK on the installation system.This is achieved by replacing the password when writing the log file.
Tests and Checks