Skip to content

Add no-home-volume layout for LVM installation #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add no-home-volume layout for LVM installation #3845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
452d8d3
.
recolic Sep 30, 2025
355fdf2
.
recolic Sep 30, 2025
3a3c6cb
.
recolic Sep 30, 2025
1f0b574
.
recolic Sep 30, 2025
f1ad6ea
.
recolic Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions archinstall/lib/interactions/disk_conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,9 @@ def select_lvm_config(
) -> LvmConfiguration | None:
preset_value = preset.config_type.display_msg() if preset else None
default_mode = LvmLayoutType.Default.display_msg()
no_home = LvmLayoutType.NoHome.display_msg()

items = [MenuItem(default_mode, value=default_mode)]
items = [MenuItem(default_mode, value=default_mode), MenuItem(no_home, value=no_home)]
group = MenuItemGroup(items)
group.set_focus_by_value(preset_value)

Expand All @@ -218,6 +219,8 @@ def select_lvm_config(
case ResultType.Selection:
if result.get_value() == default_mode:
return suggest_lvm_layout(disk_config)
if result.get_value() == no_home:
return suggest_lvm_layout(disk_config, home_volume=False)

return None

Expand Down Expand Up @@ -551,13 +554,13 @@ def suggest_lvm_layout(
disk_config: DiskLayoutConfiguration,
filesystem_type: FilesystemType | None = None,
vg_grp_name: str = 'ArchinstallVg',
home_volume: bool = True
) -> LvmConfiguration:
if disk_config.config_type != DiskLayoutType.Default:
raise ValueError('LVM suggested volumes are only available for default partitioning')

using_subvolumes = False
btrfs_subvols = []
home_volume = True
mount_options = []

if not filesystem_type:
Expand Down Expand Up @@ -602,7 +605,7 @@ def suggest_lvm_layout(
[p.length for p in other_part],
Size(0, Unit.B, SectorSize.default()),
)
root_vol_size = Size(20, Unit.GiB, SectorSize.default())
root_vol_size = Size(20, Unit.GiB, SectorSize.default()) if home_volume else total_vol_available
home_vol_size = total_vol_available - root_vol_size

lvm_vol_group = LvmVolumeGroup(vg_grp_name, pvs=other_part)
Expand Down
5 changes: 4 additions & 1 deletion archinstall/lib/models/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,13 +1070,16 @@ def table_data(self) -> dict[str, str]:

class LvmLayoutType(Enum):
Default = 'default'
NoHome = 'no_home'

# Manual = 'manual_lvm'

def display_msg(self) -> str:
match self:
case LvmLayoutType.Default:
return tr('Default layout')
return tr('Default layout (root volume + seperate home volume)')
case LvmLayoutType.NoHome:
return tr('No home layout (root volume only)')
# case LvmLayoutType.Manual:
# return str(_('Manual configuration'))

Expand Down