Skip to content

Conversation

@systemofapwne
Copy link
Contributor

PR Description:

When using archinstall --skip-boot (no bootloader), the installation can get blocked with a message like Root partition not found in the TUI for certain setups such as

  • pre_mounted_config to /mnt with a setup like this
disk layout like this caused it for me
root@archiso ~ # lsblk
NAME              MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINTS
loop0               7:0    0 957.1M  1 loop  /run/archiso/airootfs
sda                 8:0    0    20G  0 disk  
├─sda1              8:1    0     1M  0 part  
├─sda2              8:2    0   550M  0 part  /mnt/efi
└─sda3              8:3    0  19.5G  0 part  
  └─cryptroot     253:0    0  19.4G  0 crypt 
    ├─system-boot 253:1    0     1G  0 lvm   /mnt/boot
    ├─system-swap 253:2    0     1G  0 lvm   [SWAP]
    └─system-pool 253:3    0  17.4G  0 lvm   /mnt/home
                                             /mnt/var/tmp
                                             /mnt/var/spool
                                             /mnt/var/log
                                             /mnt/var/cache
                                             /mnt/srv
                                             /mnt/root
                                             /mnt/.snapshots
                                             /mnt

Where system-pool is a BTRFS pool with these mount points

[root@archiso /]# findmnt
TARGET                        SOURCE                                 FSTYPE   OPTIONS
/                             /dev/mapper/system-pool[/@]            btrfs    rw,relatime,space_cache=v2,subvolid=257,subvol=/@
├─/.snapshots                 /dev/mapper/system-pool[/snapshots/@]  btrfs    rw,noatime,space_cache=v2,subvolid=256,subvol=/snapshots/@
├─/efi                        /dev/sda2                              vfat     rw,relatime,fmask=0777,dmask=0777,codepage=437,iocharset=iso8859-1,sho
├─/boot                       /dev/mapper/system-boot                ext4     rw,relatime
├─/root                       /dev/mapper/system-pool[/root]         btrfs    rw,relatime,space_cache=v2,subvolid=258,subvol=/root
├─/srv                        /dev/mapper/system-pool[/srv]          btrfs    rw,relatime,space_cache=v2,subvolid=259,subvol=/srv
├─/var/cache                  /dev/mapper/system-pool[/var/cache]    btrfs    rw,noatime,space_cache=v2,subvolid=260,subvol=/var/cache
├─/var/log                    /dev/mapper/system-pool[/var/log]      btrfs    rw,noatime,space_cache=v2,subvolid=261,subvol=/var/log
├─/var/spool                  /dev/mapper/system-pool[/var/spool]    btrfs    rw,noatime,space_cache=v2,subvolid=262,subvol=/var/spool
├─/var/tmp                    /dev/mapper/system-pool[/var/tmp]      btrfs    rw,nosuid,nodev,noexec,noatime,space_cache=v2,subvolid=263,subvol=/var
├─/home                       /dev/mapper/system-pool[/home]         btrfs    rw,noatime,space_cache=v2,subvolid=264,subvol=/home
├─/tmp                        tmpfs                                  tmpfs    rw,nosuid,nodev,noexec,relatime,mode=1700,inode64
│ └─/tmp                      tmp                                    tmpfs    rw,nosuid,nodev,inode64
├─/etc/resolv.conf            run[/systemd/resolve/stub-resolv.conf] tmpfs    rw,nosuid,nodev,relatime,mode=755,inode64
├─/proc                       proc                                   proc     rw,nosuid,nodev,noexec,relatime
├─/sys                        sys                                    sysfs    ro,nosuid,nodev,noexec,relatime
│ └─/sys/firmware/efi/efivars efivarfs                               efivarfs rw,nosuid,nodev,noexec,relatime
├─/dev                        udev                                   devtmpfs rw,nosuid,relatime,size=3933220k,nr_inodes=983305,mode=755,inode64
│ ├─/dev/pts                  devpts                                 devpts   rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000
│ └─/dev/shm                  shm                                    tmpfs    rw,nosuid,nodev,relatime,inode64
└─/run                        run                                    tmpfs    rw,nosuid,nodev,relatime,mode=755,inode64

The message is caused by archinstall.lib.global_menu._validate_bootloader still performing validity checks for the bootloader configuration, even when no bootloader shall be installed. This PR simply skips the check, if no bootloader shall be installed.

Tests and Checks

  • I have tested the code!

@systemofapwne systemofapwne requested a review from Torxed as a code owner October 19, 2025 16:06
Fixed ruff formatting issue
Copy link
Member

@Torxed Torxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and thank you for this fix.
Apologies for the delay in getting back on this, life has been kicking me a bit so I haven't had time.

@Torxed Torxed merged commit 1174800 into archlinux:master Nov 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants