Skip to content

Change classmethods to staticmethods #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Jan 11, 2026
Merged

Change classmethods to staticmethods #4114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions archinstall/lib/disk/fido.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,8 @@ def get_cryptenroll_devices(cls, reload: bool = False) -> list[Fido2Device]:

return cls._cryptenroll_devices

@classmethod
def fido2_enroll(
cls,
hsm_device: Fido2Device,
dev_path: Path,
password: Password,
) -> None:
@staticmethod
def fido2_enroll(hsm_device: Fido2Device, dev_path: Path, password: Password) -> None:
worker = SysCommandWorker(f'systemd-cryptenroll --fido2-device={hsm_device.path} {dev_path}', peek_output=True)
pw_inputted = False
pin_inputted = False
Expand Down
3 changes: 1 addition & 2 deletions archinstall/lib/models/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,9 +1495,8 @@ def json(self) -> _DiskEncryptionSerialization:

return obj

@classmethod
@staticmethod
def validate_enc(
cls,
modifications: list[DeviceModification],
lvm_config: LvmConfiguration | None = None,
) -> bool:
Expand Down
4 changes: 2 additions & 2 deletions archinstall/lib/models/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ def from_wpa_cli_output(cls, list_networks: str) -> list[WifiConfiguredNetwork]:

return networks

@classmethod
def _extract_flags(cls, flag_string: str) -> list[str]:
@staticmethod
def _extract_flags(flag_string: str) -> list[str]:
Copy link
Contributor Author

@codefiles codefiles Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused code. There is a commented out call to this method above.

pattern = r'\[([^\]]+)\]'

extracted_values = re.findall(pattern, flag_string)
Expand Down
7 changes: 3 additions & 4 deletions archinstall/lib/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@


class FormattedOutput:
@classmethod
@staticmethod
def _get_values(
cls,
o: 'DataclassInstance',
class_formatter: str | Callable | None = None, # type: ignore[type-arg]
filter_list: list[str] = [],
Expand Down Expand Up @@ -110,8 +109,8 @@ def as_table(

return output

@classmethod
def as_columns(cls, entries: list[str], cols: int) -> str:
@staticmethod
def as_columns(entries: list[str], cols: int) -> str:
"""
Will format a list into a given number of columns
"""
Expand Down