Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate redundant -mtune, when it is implied by -march #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffhammond
Copy link

This is motivated by spack/spack#43808.

I am not super optimistic that this will be accepted, but I figure it's worth a try.

@haampie
Copy link

haampie commented Apr 24, 2024

Makes sense, @alalazo can maybe comment why both flags are set.

We just set them as defaults cc -march=... -mtune=... <other args...>, meaning that our -mtune is not there to override anything from the build system.

@alalazo
Copy link
Member

alalazo commented Apr 24, 2024

Given the way it is currently used in Spack it wouldn't make a difference.

I'm wondering if we use it the right way though. On the one hand we want to allow libraries etc. to dispatch at runtime if they want to (and not be forced to a single target), but on the other hand I think we'd also like that generic targets on a spec keep their promise 🤔

Also, in terms of a generic library (archspec), the current flags, if appended, would ensure a complete override with uarch specific settings. If we delete mtune we leave tuning to whatever previous option was possibly set.

Not sure what would be best. @tgamblin Any thought on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants