-
Notifications
You must be signed in to change notification settings - Fork 16
Disable safety timer in PMICClass::disableWatchdog
#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
commit from issue on Arduino's repo arduino-libraries#11
LGTM! |
yep sure |
i remember why we leaved the charge safety timer enabled, disable this timer could results in a dangerous event if the charge time is too long, maybe more than disable it permanently could be better allows for manually disable it by the user? |
@Rocketct |
yes in that case have a lot more sense, so the best thing could be modify the disableWatchdog in order that just disable the watchdog and inside the disableCharge add the disable safety timer, in this case shall be also added the enable charge timer in the enableCharge, i'll made the pr asap |
Who can press the merge button @per1234 @Rocketct ? Whats the holdup? Side note, what is the difference between disableCharge and disableCharging ? Another side note, imagine how many people do not use battery charging function at all (MKR WiFi 1010 and others), yet they will have to stare at a stupid blinking LED because it is on per default. Even if this merge request eventually manages to get in, all these users will have to include a whole charging lib just to disable it. |
PMICClass::disableWatchdog
Creating a Pull request regarding issue 11
Changed the code as there was some typo's in the code
#11