Skip to content

Disable safety timer in PMICClass::disableWatchdog #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stefanhg
Copy link

@Stefanhg Stefanhg commented Jun 5, 2022

Creating a Pull request regarding issue 11
Changed the code as there was some typo's in the code
#11

commit from issue on Arduino's repo
arduino-libraries#11
@facchinm
Copy link
Contributor

facchinm commented Jun 6, 2022

LGTM!
@Rocketct can you test it on a board (and also check why some examples are not compiling anymore to make the CI green again) ?

@Rocketct
Copy link
Contributor

Rocketct commented Jun 6, 2022

yep sure

@Rocketct
Copy link
Contributor

Rocketct commented Jun 9, 2022

i remember why we leaved the charge safety timer enabled, disable this timer could results in a dangerous event if the charge time is too long, maybe more than disable it permanently could be better allows for manually disable it by the user?
i also found why the others examples doesn't compile i'll fix them and push in another PR

@Stefanhg
Copy link
Author

Stefanhg commented Jun 9, 2022

@Rocketct
In my case i actually wanted to disable charging permanently.
It could also be considered if this should be in disableCharging instead of disableWatchdog.
AS it is kind of pointless of having a disableCharging if it enables after 1 hour anyways

@Rocketct
Copy link
Contributor

Rocketct commented Jun 10, 2022

yes in that case have a lot more sense, so the best thing could be modify the disableWatchdog in order that just disable the watchdog and inside the disableCharge add the disable safety timer, in this case shall be also added the enable charge timer in the enableCharge, i'll made the pr asap

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself status: changes requested Changes to PR are required before merge labels Jun 23, 2022
@s0rent
Copy link

s0rent commented Jan 24, 2025

Who can press the merge button @per1234 @Rocketct ? Whats the holdup?

Side note, what is the difference between disableCharge and disableCharging ?
They do two different things, both are described as "Disable the battery charger", none of them disable the battery LED which will start blinking if no battery is connected.

Another side note, imagine how many people do not use battery charging function at all (MKR WiFi 1010 and others), yet they will have to stare at a stupid blinking LED because it is on per default. Even if this merge request eventually manages to get in, all these users will have to include a whole charging lib just to disable it.

@per1234 per1234 linked an issue Jan 24, 2025 that may be closed by this pull request
@per1234 per1234 changed the title Update BQ24195.cpp Disable safety timer in PMICClass::disableWatchdog Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes requested Changes to PR are required before merge topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to disable Charging Safety Timer
5 participants