Avoid connect to APN to loop forever in case of missing connection #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 56d0bc2
Click for full report table
Click for full report CSV |
sebromero
requested changes
Jan 23, 2025
maidnl
force-pushed
the
opta_cellular_dev
branch
from
56d0bc2 to
e436eab
Compare
|
Thanks @sebromero. The PR is updated with your observations. |
|
Memory usage change @ e436eab
Click for full report table
Click for full report CSV |
facchinm
approved these changes
Jan 23, 2025
maidnl
force-pushed
the
opta_cellular_dev
branch
from
e436eab to
4606dbf
Compare
|
Memory usage change @ 4606dbf
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
sebromero
requested changes
Feb 26, 2025
| /** | ||
| * @brief same as previous, username and password are empty | ||
| */ | ||
| bool connect(String apn, bool waitForever); |
There was a problem hiding this comment.
Suggested change
| bool connect(String apn, bool waitForever); | |
| bool connect(String apn, bool waitForever = true); |
I'd assign the same default value to the version without credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 changes (those changes have been found useful during Arduino Opta Cellular development, that uses this library):
getSimStatus()is now public (it is useful to have the chance to know if the SIM is available or it has to be unlocked)connectfunction in case the connection to the APN is not available (for example the antenna is missing and so a reliable communication cannot be established) was blocking. With this PR a parameter has been introduced to choose if the function must remain blocking (default) or it exits after a timeout.