-
Notifications
You must be signed in to change notification settings - Fork 3
Cbor messages #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cbor messages #17
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
234e9ca
to
f5ae3f4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b59e9e8
to
26ef18a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d96dc56
to
897c622
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
900c43e
to
9bcf78d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
326dbac
to
bb59ceb
Compare
bf817df
to
abb7f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/interfaces/Decoder.h could potentially clash with src/lzss/decoder.h so i would rename one or the other
Decoder Encoder and message interfaces are not shared among all libraries modules, so i would move them inside the src/cbor folder. If in the future they become shared interfaces we will move them in a shared interfaces folder
What about the FIXME and TODO comments ? They should be solved before merging the PR or are leftovers?
abb7f27
to
a5642c1
Compare
805d90a
to
d613a6f
Compare
I will rename the following However I don't see the clash, the filename is the same, but the directory structure should be enough to differentiate between those names, otherwise I don't see any advantage of using sub directories. Am I missing something hidden in the build system? |
d613a6f
to
2934dbc
Compare
No, you are rigth, there is no clash. I did not think about folders and considered only the name 🙂 Anyway What about the //FIXME better names, and other //TODO comments ? Are you still thinking about renaming ? Otherwise i will remove the comments and merge the PR. |
2934dbc
to
5fd19ba
Compare
Memory usage change @ 5fd19ba
Click for full report table
Click for full report CSV
|
Creating a module to handle CBOR message encode and decode for Arduino Cloud related features