-
Notifications
You must be signed in to change notification settings - Fork 3
Get cloud jwt no ecc #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pennam
wants to merge
4
commits into
arduino-libraries:main
Choose a base branch
from
pennam:get-cloud-jwt-no-ecc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 916049c
Click for full report table
Click for full report CSV
|
916049c
to
4900feb
Compare
Memory usage change @ 4900feb
Click for full report table
Click for full report CSV
|
andreagilardoni
requested changes
Apr 16, 2025
namespace arduino { namespace b64 { | ||
|
||
String urlEncode(const byte in[], unsigned int length); | ||
String encode(const byte in[], unsigned int length, const char* prefix, const char* suffix); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we define only encode this way? It seems a bit redundant the definition
Suggested change
String encode(const byte in[], unsigned int length, const char* prefix, const char* suffix); | |
String encode(const byte in[], unsigned int length, const char* prefix=nullptr, const char* suffix=nullptr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.