Skip to content

ci: remove libraries from compile-examples.yml workflow#30

Draft
aliphys wants to merge 2 commits intomainfrom
aliphys/noLibraryInWorkflowPlz
Draft

ci: remove libraries from compile-examples.yml workflow#30
aliphys wants to merge 2 commits intomainfrom
aliphys/noLibraryInWorkflowPlz

Conversation

@aliphys
Copy link
Copy Markdown
Contributor

@aliphys aliphys commented Nov 17, 2023

This PR removes the explicit mention of the libraries in the workflow file.

- name: Arduino_USBHostMbed5
- name: Arduino_POSIXStorage
- name: ArduinoRS485

Following #29 and this PR all three dependancies are listed inside the library.properties file.

@aliphys aliphys added the topic: infrastructure Related to project infrastructure label Nov 17, 2023
@aliphys
Copy link
Copy Markdown
Contributor Author

aliphys commented Nov 17, 2023

Although the dependancies are listed in the library.properties file they do not seem to be loaded by the runner: https://github.com/arduino-libraries/Arduino_UnifiedStorage/actions/runs/6906243043/job/18790834190#step:3:211


Compiling sketch: extras/tests/TestExisting
  In file included from /home/runner/work/Arduino_UnifiedStorage/Arduino_UnifiedStorage/extras/tests/TestExisting/TestExisting.ino:4:0:
  /home/runner/Arduino/libraries/Arduino_UnifiedStorage/src/Arduino_UnifiedStorage.h:6:10: fatal error: Arduino_POSIXStorage.h: No such file or directory
   #include "Arduino_POSIXStorage.h"
            ^~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  
  
  Used library           Version Path                                                           
  Arduino_UnifiedStorage 1.1.1   /home/runner/work/Arduino_UnifiedStorage/Arduino_UnifiedStorage
  
  Used platform     Version Path                                                             
  arduino:mbed_opta 4.0.8   /home/runner/.arduino15/packages/arduino/hardware/mbed_opta/4.0.8
  Error during build: exit status 1

@per1234 Can you share your thoughts on this?

@aliphys aliphys requested a review from per1234 November 17, 2023 16:05
Copy link
Copy Markdown
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arduino/compile-sketches action does not automatically install the libraries listed in the depends field of library.properties. So you must explicitly specify the library dependencies that should be installed in the GitHub Actions workflow, as was done previously.

There is no such capability by default because the action does not install the Arduino_UnifiedStorage library via Library Manager. Instead, it is being manually installed from the checked out repository.

The addition of such a capability, where the action parses the library.properties file and then automatically installs the libraries found there, has been proposed but the feature was not implemented so far.

@sebromero
Copy link
Copy Markdown
Contributor

@aliphys Any update on this?

@aliphys
Copy link
Copy Markdown
Contributor Author

aliphys commented Dec 6, 2023

@sebromero This fix is dependant upon arduino/compile-sketches#205 being merged.

@per1234 per1234 added type: enhancement Proposed improvement status: blocked Progress on this prevented by an external cause labels Dec 7, 2023
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: blocked Progress on this prevented by an external cause topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants