Skip to content

fix for knob press #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: joystick
Choose a base branch
from
Open

Conversation

Rocketct
Copy link

this change with the fps fix resolve the #20 issue, call the update before the get or is pressed allows to avoid false negative reading from the i2s bus

@leonardocavagnis
Copy link
Contributor

@Rocketct LGTM :)

Please, could you add update() function to the api.md document?
https://github.com/arduino-libraries/Modulino/blob/main/docs/api.md#modulinoknob

@sebromero
Copy link

I suggest to move the whole API documentation to the header file and use the GH action that I created to render the API docs automatically: https://github.com/arduino/render-docs-github-action

@Rocketct
Copy link
Author

@leonardocavagnis done added last fix you can test on yours side and then merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants