Fix increase in ssl error for MacOS users #10747
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. Please test this code using one of the following: ⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10747-BUILD-984-linux32.tar.xz ℹ️ The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've disabled the auto-search for system-installed JVM (to use, when found, instead of the bundled one) and should fix the increase ssl errors recently reported by macos users.
Even if it looks like the best thing to do long term, turned out that this feature creates more confusion to users having an older version of the JVM already installed that is incompatible with the current IDE (and it seems that this is a very common case).
Moreover, the current versions of the Oracle JVM 8 generate the SSL errors reported here:
#10685
#10563
It's not clear if this is due to appbundler or is due to the fact that we run java code compiled for an older runtime on a newer runtime.