Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuildProgrammerMenu: Handle no current board #10922

Merged

Conversation

matthijskooijman
Copy link
Collaborator

@matthijskooijman matthijskooijman commented Nov 4, 2020

rebuildProgrammerMenu: Handle no current board

This can happen happen in some unlikely cases (such as when renaming a
platform in a way that breaks the "select a board when none is selected
logic").

Even though a board should always be selected, code should still handle
no selected board gracefully (rather than raising a NullPointerException
like this used to do).

See #10887 for the underlying issue that caused no board to be selected.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This can happen happen in some unlikely cases (such as when renaming a
platform in a way that breaks the "select a board when none is selected
logic").

Even though a board should always be selected, code should still handle
no selected board gracefully (rather than raising a NullPointerException
like this used to do).

See arduino#10887 for the underlying issue that caused no board to be selected.
@facchinm facchinm merged commit 76dfd0a into arduino:master Dec 1, 2020
@NicoHood
Copy link
Contributor

NicoHood commented Dec 4, 2020

Does this also fix #10580 ?

@matthijskooijman
Copy link
Collaborator Author

@NicoHood this PR would certainly solve one problem caused by having no platforms installed. There might be more, I haven't tested tihs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants