Dynamic splash image (take 2) #9935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic-only change that makes the logic of the method clearer
Closed
cmaglie
force-pushed
the
dynamic-splashscreen
branch
from
302f8ba to
87a9af3
Compare
Also moved test key into proper package.
There is no point to have this abstract class.
cmaglie
force-pushed
the
dynamic-splashscreen
branch
from
7c3b3a6 to
b0ebd79
Compare
Makes linter happy and improves readability
|
✅ Build completed. Please test this code using one of the following: ⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-9935-BUILD-946-linux32.tar.xz ℹ️ The |
cmaglie
added
the
Type: Wontfix
per1234
added
the
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on and supersedes #9827
the splash screen is now downloaded and cached
I've added an "expire" timer: if no network is available for more than 24h, the original (bundled) image is displayed again. I'm not sure this is required, in case it may be easily removed.
there is no way to make the splash screen clickable, it's not a normal JPanel, AFAIU the splashscreen is implemented natively outside of the AWT framework, so it's very limited. Also redoing it doesn't seem a quick/viable alternative, but I've not searched much.
the "About" menu now shows the same image as the splashscreen
for the moment the PR will fetch data from a webserver where I have direct control, we will change the URL to the final destination before merging.