Remove -Wno-expansion-to-defined #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
LGTM! @cmaglie are you ok in merging it? |
|
@matthijskooijman care to rebase on |
The sam.h file uses some non-portable macros that raise a warning in newer gcc version. This warning was supressed in commit 8575a52 (Add -Wno-expansion-to-defined compile warning flag), but this is not ideal. However, since the only thing sam.h does is figure out what CPU is selected and include the right family header, and we always use SAMD21 CPUs, the only thing sam.h does is include samd.h. So we can easily bypass then and include samd.h directly. This fixes the first part of arduino#556.
Now that we no longer include sam.h, this warning is no longer triggered in normal builds, so there is no longer a need to supress it. This fixes arduino#556.
matthijskooijman
force-pushed
the
remove-no-expansion-to-defined
branch
from
04339d6 to
32f7ac6
Compare
|
Just rebased. Haven't done any testing after rebasing, but let's see what the CI says :-) |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
aentinger
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By including a different CMSIS header, this warning no longer needs to be supressed.
This fixes #556.