-
Notifications
You must be signed in to change notification settings - Fork 7
[CLI] Add a destroy app command #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mirkoCrobu
wants to merge
4
commits into
main
Choose a base branch
from
issue_105_add_app_destroy_command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // This file is part of arduino-app-cli. | ||
| // | ||
| // Copyright 2025 ARDUINO SA (http://www.arduino.cc/) | ||
| // | ||
| // This software is released under the GNU General Public License version 3, | ||
| // which covers the main part of arduino-app-cli. | ||
| // The terms of this license can be found at: | ||
| // https://www.gnu.org/licenses/gpl-3.0.en.html | ||
| // | ||
| // You can be released from the requirements of the above licenses by purchasing | ||
| // a commercial license. Buying such a license is mandatory if you want to | ||
| // modify or otherwise use the software for commercial activities involving the | ||
| // Arduino software without disclosing the source code of your own applications. | ||
| // To purchase a commercial license, send an email to [email protected]. | ||
|
|
||
| package app | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/spf13/cobra" | ||
|
|
||
| "github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/completion" | ||
| "github.com/arduino/arduino-app-cli/cmd/feedback" | ||
| "github.com/arduino/arduino-app-cli/internal/orchestrator" | ||
| "github.com/arduino/arduino-app-cli/internal/orchestrator/app" | ||
| "github.com/arduino/arduino-app-cli/internal/orchestrator/config" | ||
| ) | ||
|
|
||
| func newDestroyCmd(cfg config.Configuration) *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "destroy app_path", | ||
| Short: "Destroy an Arduino App", | ||
| Args: cobra.MaximumNArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) == 0 { | ||
| return cmd.Help() | ||
| } | ||
| app, err := Load(args[0]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return destroyHandler(cmd.Context(), app) | ||
| }, | ||
| ValidArgsFunction: completion.ApplicationNamesWithFilterFunc(cfg, func(apps orchestrator.AppInfo) bool { | ||
| return apps.Status != orchestrator.StatusUninitialized | ||
| }), | ||
| } | ||
| } | ||
|
|
||
| func destroyHandler(ctx context.Context, app app.ArduinoApp) error { | ||
| out, _, getResult := feedback.OutputStreams() | ||
|
|
||
| for message := range orchestrator.DestroyAndCleanApp(ctx, app) { | ||
| switch message.GetType() { | ||
| case orchestrator.ProgressType: | ||
| fmt.Fprintf(out, "Progress[%s]: %.0f%%\n", message.GetProgress().Name, message.GetProgress().Progress) | ||
| case orchestrator.InfoType: | ||
| fmt.Fprintln(out, "[INFO]", message.GetData()) | ||
| case orchestrator.ErrorType: | ||
| feedback.Fatal(message.GetError().Error(), feedback.ErrGeneric) | ||
| return nil | ||
| } | ||
| } | ||
| outputResult := getResult() | ||
|
|
||
| feedback.PrintResult(destroyAppResult{ | ||
| AppName: app.Name, | ||
| Status: "uninitialized", | ||
| Output: outputResult, | ||
| }) | ||
| return nil | ||
| } | ||
|
|
||
| type destroyAppResult struct { | ||
| AppName string `json:"appName"` | ||
| Status string `json:"status"` | ||
| Output *feedback.OutputStreamsResult `json:"output,omitempty"` | ||
| } | ||
|
|
||
| func (r destroyAppResult) String() string { | ||
| return fmt.Sprintf("✓ App '%q destroyed successfully.", r.AppName) | ||
| } | ||
|
|
||
| func (r destroyAppResult) Data() interface{} { | ||
| return r | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.