Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zipped sketch with embedded libraries #223

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container_setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ func (s *ContainerSetupHardwareToolsLibsSketchAndProps) Run(ctx *types.Context)
&ToolsLoader{},
&TargetBoardResolver{},
&AddBuildBoardPropertyIfMissing{},
&LibrariesLoader{},
&SketchLoader{},
&LibrariesLoader{},
&SetupBuildProperties{},
&LoadVIDPIDSpecificProperties{},
&SetCustomBuildProperties{},
Expand Down
4 changes: 4 additions & 0 deletions libraries_loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ func (s *LibrariesLoader) Run(ctx *types.Context) error {

sortedLibrariesFolders = appendPathToLibrariesFolders(sortedLibrariesFolders, filepath.Join(platform.Folder, constants.FOLDER_LIBRARIES))

if ctx.SketchZipped {
sortedLibrariesFolders = appendPathToLibrariesFolders(sortedLibrariesFolders, filepath.Join(filepath.Dir(ctx.SketchLocation), constants.FOLDER_LIBRARIES))
}

librariesFolders := ctx.OtherLibrariesFolders
librariesFolders, err = utils.AbsolutizePaths(librariesFolders)
if err != nil {
Expand Down
14 changes: 14 additions & 0 deletions resolve_library.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ func ResolveLibrary(ctx *types.Context, header string) *types.Library {

library = useAlreadyImportedLibraryWithSameNameIfExists(library, importedLibraries)

if ctx.SketchZipped {
// select embedded library, in any case
library = libraryContainedInSketchFolder(libraries, filepath.Dir(ctx.SketchLocation))
}

libraryResolutionResults[header] = types.LibraryResolutionResult{
Library: library,
NotUsedLibraries: filterOutLibraryFrom(libraries, library),
Expand Down Expand Up @@ -119,6 +124,15 @@ func useAlreadyImportedLibraryWithSameNameIfExists(library *types.Library, impor
return library
}

func libraryContainedInSketchFolder(libraries []*types.Library, sketchFolder string) *types.Library {
for _, lib := range libraries {
if strings.Contains(lib.Folder, sketchFolder) {
return lib
}
}
return libraries[0]
}

func filterOutLibraryFrom(libraries []*types.Library, libraryToRemove *types.Library) []*types.Library {
filteredOutLibraries := []*types.Library{}
for _, lib := range libraries {
Expand Down
31 changes: 30 additions & 1 deletion sketch_loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
package builder

import (
"bufio"
"io/ioutil"
"net/http"
"os"
"path/filepath"
"sort"
Expand Down Expand Up @@ -63,6 +65,17 @@ func (s *SketchLoader) Run(ctx *types.Context) error {
sketchLocation = filepath.Join(sketchLocation, mainSketchStat.Name()+".ino")
}

if mimeType(sketchLocation) == "application/zip" {
dir, _ := ioutil.TempDir("", "arduino_sketch_zip_temp")
sketchLocation, err = utils.ExtractZip(sketchLocation, dir)
if err != nil {
panic(err)
}
mainSketchFileName := filepath.Base(sketchLocation) + ".ino"
sketchLocation = filepath.Join(sketchLocation, mainSketchFileName)
ctx.SketchZipped = true
}

ctx.SketchLocation = sketchLocation

allSketchFilePaths, err := collectAllSketchFiles(filepath.Dir(sketchLocation))
Expand All @@ -72,7 +85,7 @@ func (s *SketchLoader) Run(ctx *types.Context) error {

logger := ctx.GetLogger()

if !utils.SliceContains(allSketchFilePaths, sketchLocation) {
if !utils.SliceContains(allSketchFilePaths, sketchLocation) && !ctx.SketchZipped {
return i18n.ErrorfWithLogger(logger, constants.MSG_CANT_FIND_SKETCH_IN_PATH, sketchLocation, filepath.Dir(sketchLocation))
}

Expand All @@ -87,6 +100,22 @@ func (s *SketchLoader) Run(ctx *types.Context) error {
return nil
}

func mimeType(fileName string) string {
fs, err := os.Open(fileName)

if err != nil {
return ""
}

defer fs.Close()

reader := bufio.NewReader(fs)

buf := make([]byte, 512)
reader.Read(buf)
return http.DetectContentType(buf)
}

func collectAllSketchFiles(from string) ([]string, error) {
filePaths := []string{}
// Source files in the root are compiled, non-recursively. This
Expand Down
3 changes: 3 additions & 0 deletions types/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ type Context struct {
Verbose bool
DebugPreprocessor bool

// inoz handling
SketchZipped bool

// Dry run, only create progress map
Progress ProgressStruct

Expand Down
65 changes: 65 additions & 0 deletions utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
package utils

import (
"archive/zip"
"bytes"
"crypto/md5"
"encoding/hex"
Expand Down Expand Up @@ -585,6 +586,70 @@ func ParseCppString(line string) (string, string, bool) {
}
}

func ExtractZip(filePath string, location string) (string, error) {
r, err := zip.OpenReader(filePath)
if err != nil {
return location, err
}

var dirList []string

for _, f := range r.File {
fullname := filepath.Join(location, strings.Replace(f.Name, "", "", -1))
if f.FileInfo().IsDir() {
dirList = append(dirList, fullname)
os.MkdirAll(fullname, 0755)
} else {
_, err := os.Stat(filepath.Dir(fullname))
if err != nil {
dirList = append(dirList, filepath.Dir(fullname))
os.MkdirAll(filepath.Dir(fullname), 0755)
}
perms := f.FileInfo().Mode().Perm()
out, err := os.OpenFile(fullname, os.O_CREATE|os.O_RDWR, perms)
if err != nil {
return location, err
}
rc, err := f.Open()
if err != nil {
return location, err
}
_, err = io.CopyN(out, rc, f.FileInfo().Size())
if err != nil {
return location, err
}
rc.Close()
out.Close()

mtime := f.FileInfo().ModTime()
err = os.Chtimes(fullname, mtime, mtime)
if err != nil {
return location, err
}
}
}
basedir := filepath.Base(findBaseDir(dirList))
return filepath.Join(location, basedir), nil
}

func findBaseDir(dirList []string) string {
baseDir := ""
minLen := 256
// https://github.com/backdrop-ops/contrib/issues/55#issuecomment-73814500
dontdiff := []string{"pax_global_header"}
for _, dir := range dirList {
if SliceContains(dontdiff, dir) {
continue
}
//get the shortest string
if len(dir) < minLen {
baseDir = dir
minLen = len(dir)
}
}
return baseDir
}

func isMn(r rune) bool {
return unicode.Is(unicode.Mn, r) // Mn: nonspacing marks
}
Expand Down