Skip to content

regression: fixed ARDUINO_USER_AGENT pollution / resolve compile-sketch GH action failure on Teensy #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2024
Merged

regression: fixed ARDUINO_USER_AGENT pollution / resolve compile-sketch GH action failure on Teensy #2669

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dde80e
Removed useless gRPCClientUnknown tag
cmaglie Jul 17, 2024
7f8ad1f
'task build' now uses a compliant semver notation
cmaglie Jul 17, 2024
aae8c8a
Revert "'task build' now uses a compliant semver notation"
cmaglie Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions commands/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ func (s *arduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateReque
if md, ok := metadata.FromIncomingContext(ctx); ok {
userAgent = strings.Join(md.Get("user-agent"), " ")
}
if userAgent == "" {
userAgent = "gRPCClientUnknown/0.0.0"
}

// Setup downloads directory
downloadsDir := s.settings.DownloadsDir()
Expand Down
Loading