[WIP] Use theia@latest
#2654
Draft
[WIP] Use theia@latest
#2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Use changes from #2362 and rebase on main branch
giacomocusinato
force-pushed
the
use-theia-latest
branch
from
4d57906 to
6e9577a
Compare
Remove `EditorCommandContribution` override, since https://redirect.github.com/eclipse-theia/theia/pull/13683 fixed the unwanted save on startup
Note: align SidebarBottomMenuWidget with Theia new API and HTML structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Based on #2362
First commit (8291626) includes all changes from #2363 rebased into main branch.
Other notable changes:
EditorCommandContributionoverride (1fa0def), since Theia runs save on app startup if"editor.autoSave": "on"is configured in the settings.json eclipse-theia/theia#8722 has been fixed in[email protected]through this PRUpgrade yarn.lock dependencies. After the upgrade, some custom package resolutions is required, see https://redirect.github.com/eclipse-theia/theia/issues/14652
Other information
Reviewer checklist