Conversation
There was a problem hiding this comment.
maybe we should remove this thing, is it even working?
There was a problem hiding this comment.
Yes, it is working and still useful and used
There was a problem hiding this comment.
Ok, I removed the unused setEnv, but getEnv is still used at 2 places, however given that they both require different part of the env related stuff I wonder if it wouldn't be best to just move each where used.
Idk if best to have 1 place for all env related stuff or 2 places each getting what they need.
I'm more for leaving it as is now, but open to counter args
There was a problem hiding this comment.
not sure what's the point of the env.ts file, it was created to allow injection of an env for things like the browser, but that requires lazy initialization. we might as well remove it completely and leave it as it was before
There was a problem hiding this comment.
I quite like the idea to have everything related to env in one file rather than scattered all around
|
Once agreed to not change anything, ping me so that I can make a release and upgrade all consumers to it |
2 participants
https://www.notion.so/argenthq/Maintenance-2f0605a214fb803f9a98d326dd571b42