New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vLLM v1 compatibility #1121

Open

Atry wants to merge 2 commits into argilla-io:main from Atry:patch-1

+4 −1

Atry commented Feb 15, 2025

Don't delete model_executor if it does not exist, e.g. when VLLM_USE_V1 is set.

See https://docs.vllm.ai/en/stable/serving/env_vars.html and https://github.com/vllm-project/vllm/blob/main/vllm/v1/engine/llm_engine.py

Atry and others added 2 commits

February 14, 2025 19:34


          Fix vLLM v1 compatibility

24cd13e

Don't delete model_executor if it does not exist, e.g. when VLLM_USE_V1 is set


          [pre-commit.ci] auto fixes from pre-commit.com hooks

9df6612

for more information, see https://pre-commit.ci

plaguss approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet