Dependency update: ndarray.

[npatsakula]

Plan

• Cargo.toml update.
• GitHub CI test suite update.

[npatsakula]

Hi @stefan-k!

Can I ask you to take a look into this? Unfortunately, I can't even run a CI job here:(

[stefan-k]

Hi @npatsakula , thank you for your contribution! :) For new contributors, the CI has to be started explicitly by me.
I'm afraid a proper review will have to wait until after the holidays du to other obligations :/ Apologies!

[stefan-k]

Hi @npatsakula , this looks good to me, any idea why the CI is failing? I suspect that you'll also have to update ndarray in crates/finitediff/Cargo.toml.

[amfaber]

Hello! I've touched up this PR in npatsakula#1
argmin-math was breaking since we were not aliasing the new "ndarray_0_16" to "ndarray". This fixes the nolinalg version, but ndarray-linalg still hasn't released a version thats compatible with 0.16 (rust-ndarray/ndarray-linalg#391) , so in order to fix that we need to wait for an upstream release.
The argmin-math tests complete successfully on my machine now, but argmin itself relies on the linalg version so thats still breaking

[stefan-k]

Thanks! Hopefully a new version of ndarray-linalg will be release soon and then we can merge this :)

[amfaber]

Now that ndarray-linalg has released a new version, I've moved argmin's upgrading forward over in npatsakula#2

[npatsakula]

Hello @amfaber! Sorry for the absence and thank you for your MR's!

Hello @stefan-k! I've merged @amfaber MR but some examples still unable to complile with outdated version of finitediff ([email protected]support (df8d4dd) on master). Can I ask you to publish new version on crates.io in order to fix build?

[npatsakula]

False alarm: all examples compile without errors after rebase 👌🏼

[npatsakula]

Hello @stefan-k! Can I ask you for review?

[amfaber]

I would also love to see progress on this :)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (40a25e6) to head (71ced29).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   92.11%   92.10%   -0.02%     
==========================================
  Files         177      177              
  Lines       23672    23675       +3     
==========================================
  Hits        21806    21806              
- Misses       1866     1869       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.