refactor(github): simplify validation logic and remove nolint annotat…#4065
Open
pillatipriyanka wants to merge 2 commits into
Open
Conversation
pillatipriyanka
force-pushed
the
pillatipriyanka_github-validate-remove-nolint
branch
from
d0fba34 to
cfe4a57
Compare
…ions Signed-off-by: pillati lakshmi priyanka <pillatilakshmi@gmail.com>
pillatipriyanka
force-pushed
the
pillatipriyanka_github-validate-remove-nolint
branch
from
cfe4a57 to
06e42cf
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors GitHub EventSource validation logic for readability while preserving existing behavior.
Changes:
- Simplifies
ContentTypevalidation by using a local variable and positive comparisons. - Replaces paired base/upload URL validation with boolean presence checks.
- Removes obsolete
//nolint:staticcheckannotations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies validation logic in the GitHub EventSource validator by replacing negated/or conditions and removing //nolint:staticcheck annotations. The change preserves behavior but improves clarity and satisfies static analysis.
Files changed:
pkg/eventsources/sources/github/validate.go
No functional changes expected.