chore: Refactor the method creating sync tasks #618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, during my work on ArgoCD I noticed that quite a few methods in GitOps engine are quite large, and are not broken down into smaller, understandable methods. This has made it very hard for me to understand what the methods and functions do, as I had to keep very large information present in my mind, in order to understand them.
In this PR I have extracted blocks of code into hopefully more understandable, smaller methods and functions. For me the code is more readable now, because:
If this change is welcome I would like to do similar changes other methods as well.
Note that there are few other changes which could be done, but I felt that I would need to write additional tests to cover this behavior, which is currently out of scope for me, as I am both only vaguely familiar with Golang, and even less so with this codebase.