Skip to content

Add new API to propagate context and deprecate olds #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sivchari
Copy link
Contributor

This is part of argoproj/argo-cd#21963
I added new API to propagate context for each function and deprecate olds that doesn't have cotnext.

@sivchari sivchari requested a review from a team as a code owner April 20, 2025 14:42
@sivchari sivchari force-pushed the add-interfaces-including-context branch 3 times, most recently from fb7494a to db43c8e Compare April 20, 2025 15:10
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 50 lines in your changes missing coverage. Please review.

Project coverage is 53.40%. Comparing base (8849c3f) to head (45bcf56).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 34.48% 17 Missing and 2 partials ⚠️
pkg/utils/kube/ctl.go 0.00% 11 Missing ⚠️
pkg/health/health.go 30.76% 8 Missing and 1 partial ⚠️
pkg/utils/kube/resource_ops.go 0.00% 8 Missing ⚠️
pkg/diff/diff.go 0.00% 2 Missing ⚠️
pkg/utils/kube/kubetest/mock.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
- Coverage   54.26%   53.40%   -0.87%     
==========================================
  Files          64       64              
  Lines        6164     6522     +358     
==========================================
+ Hits         3345     3483     +138     
- Misses       2549     2760     +211     
- Partials      270      279       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sivchari sivchari force-pushed the add-interfaces-including-context branch from db43c8e to 45bcf56 Compare April 21, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant