Skip to content

CI: add arm image #16268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

CI: add arm image #16268

merged 2 commits into from
Oct 27, 2025
+127 −3

Conversation

@clonker
Copy link
Member

@clonker clonker commented Oct 24, 2025

No description provided.

@clonker clonker force-pushed the add_arm_image branch 3 times, most recently from 165dd8f to 50191c9 Compare October 24, 2025 11:00
TBerk185

This comment was marked as spam.

Sign in to view

r0qs
r0qs reviewed Oct 27, 2025
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Also, please fix the indentation, some places use spaces while others use tabs in the Dockerfile

@github-actions
Copy link

ghcr.io/argotorg/solidity-buildpack-deps:ubuntu2404.arm-1 [ghcr.io/argotorg/solidity-buildpack-deps@sha256:6cdb928fa8743d0b5d515c2c489b8d545c541f2370af28d5d3a71532056a0f22].

r0qs
r0qs approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the concerns I shared with you on matrix, this PR look fine to me. I will do the refactor that I mentioned to you in another PR and propose it on our next call ;)

@clonker clonker merged commit 8cb16a1 into develop Oct 27, 2025
85 of 86 checks passed
@clonker clonker deleted the add_arm_image branch October 27, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0qs r0qs r0qs approved these changes

+1 more reviewer

@TBerk185 TBerk185 TBerk185 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clonker @r0qs @TBerk185