Skip to content

fix(type): anchor UUID #versioned regex to reject partial matches #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WolfieLeader wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

fix(type): anchor UUID #versioned regex to reject partial matches #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333eefd
fix(type): anchor UUID #versioned regex to reject partial matches (#1…
WolfieLeader Mar 19, 2026
c1fdf7d
style: fix prettier formatting in uuid test
WolfieLeader Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ark/type/__tests__/keywords/uuid.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,14 @@ contextualize(() => {
'must be a UUIDv4 (was "f70b8242-dd57-5e6b-b0b7-649d997140a0")'
)
})

it("rejects partial matches", () => {
const Uuid = type("string.uuid")
attest(Uuid("dbb1e8e0-40fc-4c14-87eb-61b25d166a1b extra").toString()).snap(
'must be a UUID (was "dbb1e8e0-40fc-4c14-87eb-61b25d166a1b extra")'
)
attest(Uuid("prefix dbb1e8e0-40fc-4c14-87eb-61b25d166a1b").toString()).snap(
'must be a UUID (was "prefix dbb1e8e0-40fc-4c14-87eb-61b25d166a1b")'
)
})
})
2 changes: 1 addition & 1 deletion ark/type/keywords/string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ export const uuid = Scope.module(
"#nil": "'00000000-0000-0000-0000-000000000000'",
"#max": "'ffffffff-ffff-ffff-ffff-ffffffffffff'",
"#versioned":
/[\da-f]{8}-[\da-f]{4}-[1-8][\da-f]{3}-[89ab][\da-f]{3}-[\da-f]{12}/i,
/^[\da-f]{8}-[\da-f]{4}-[1-8][\da-f]{3}-[89ab][\da-f]{3}-[\da-f]{12}$/i,
v1: regexStringNode(
/^[\da-f]{8}-[\da-f]{4}-1[\da-f]{3}-[89ab][\da-f]{3}-[\da-f]{12}$/i,
"a UUIDv1"
Expand Down
Loading