fix(util): format collapsibleDate time without locale dependency#1603
Open
WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
Open
fix(util): format collapsibleDate time without locale dependency#1603WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
WolfieLeader wants to merge 2 commits intoarktypeio:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Clean, correct fix. The hours % 12 || 12 idiom handles all edge cases (midnight→12 AM, noon→12 PM), and conditionally building the time string is simpler than the previous approach of calling toLocaleTimeString() then stripping/rewriting parts of its output. The timeWithUnnecessarySeconds regex removal is a natural consequence. No issues found.
Author
|
Awesome pullfrog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #1494
describeCollapsibleDate()calleddate.toLocaleTimeString()which produces 24-hour format on non-US systems, causing garbled output like"14:30, January 15, 2023"instead of"2:30 PM, January 15, 2023".Replaced with locale-independent manual formatting using
getHours(),getMinutes(),getSeconds():hours % 12 || 12for correct 12-hour conversion (midnight→12, noon→12)hours < 12 ? " AM" : " PM"for suffixpad()helpertimeWithUnnecessarySecondsregex (caught by eslintno-unused-vars)Test plan
collapsibleDatetests pass unchanged (year-only, day, minutes, seconds, milliseconds, midnight, noon, AM/PM)pnpm prCheckspasses (format, lint, typecheck, full test suite)