Pass cloned date to isValidDate to render days#771
Closed
rmanganiello wants to merge 1 commit intoarqex:masterfrom
rmanganiello:fix/avoid-side-effect-rendering-days
Closed
Pass cloned date to isValidDate to render days#771rmanganiello wants to merge 1 commit intoarqex:masterfrom rmanganiello:fix/avoid-side-effect-rendering-days
isValidDate to render days#771rmanganiello wants to merge 1 commit intoarqex:masterfrom
rmanganiello:fix/avoid-side-effect-rendering-days
Conversation
Avoid rendering days side effects by cloning the date to be verified against the `isValidDate` function.
Author
|
Gentle ping: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid rendering days side effects by cloning the date to be
verified against the
isValidDatefunction.Motivation and Context
This solves an important issue in the library, if for some reason
you mutate the input date in the
isValidDatefunction, therenderDaymethod will render the mutated date instead of the original.
Checklist