-
Notifications
You must be signed in to change notification settings - Fork 263
Small things #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small things #260
Conversation
I fought my way through multiple exceptions to get this to work. I don't really know why. Now it works just fine, all the backend functions work too.
Using an in-memory database and disabling DEBUG and TEMPLATE_DEBUG.
Now there is no exceptions.
`_` is being used by gettext
- unnecessary-double-cast-or-process (C414) - unnecessary-list-comprehension-dict (C404) - unnecessary-list-comprehension-set (C403) - blank-line-with-whitespace (W293) - implicit-return (RET503)
Hello @petsagouris. Thank you for your PR. |
I've tried to get no changes to the formatting of the code. a7f8c09 introduces a ruff configuration for the linter and this PR is mostly abou fixing up linter issues. 9abb46d gets vs code to discover the tests and run then easier. There is more things I wanna do PRs for in django-ledger but cleaning up linter errors gives an excellent chance to familiarize with the code base. I was thinking, fix up the failing tests, take care of internationalization and then get to deal with some of those TODOs. :) |
@petsagouris, thank you for your contribution, and I appreciate the spirit behind it. However, I’m concerned about the idea of changing numerous lines and files simultaneously. Especially if these changes aren’t directly related to a new feature, enhancement, or bug fix. While I support code refactoring and linting, I suggest keeping your refactored branch separate. If that helps, you can create a separate branch for your refactoring. However, please ensure that your pull request is limited to the files that directly relate to the main purpose of your contribution. I look forward to seeing your contributions. Miguel |
I understand completely the sentiment, it is quite a lot to oversee. I'll keep the branch for now but I'm closing this PR since it is not really helping you out. |
Basically setting up ruff for linting on Django Ledger and doing initial passes for around 20 or so rules.
At some point that the project will require it can be very easily formatted in a unformed and automatic way.