Skip to content

Conversation

@rkendra
Copy link

@rkendra rkendra commented Dec 5, 2024

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Fixed an edge case that occurred in span_range() that caused the omission of dates when frame = 'month', exact = True, and start.day > 28.

span_range() now exhibits similar behavior to range() in this case where the returned Arrow object from span() is checked against the start date and updated accordingly.

Closes: #1185

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@85cd905). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             master     #1205   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        10           
  Lines             ?      2350           
  Branches          ?       360           
==========================================
  Hits              ?      2350           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

span_range returns unexpected result (missing days) when using frame month

2 participants