Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP => [Do Not Merge]: Add new createConversation mutation #6401

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 31, 2025

⚠️

Related:

Description

Hackathon project to allow partners to create convos from Orders.

@damassi damassi self-assigned this Jan 31, 2025
@artsy-peril
Copy link
Contributor

artsy-peril bot commented Jan 31, 2025


Warnings
⚠️ The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary.

Argument 'signed: Boolean' was removed from field 'Query.artworksConnection'
Argument 'signed: Boolean' was removed from field 'Artist.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'EntityWithFilterArtworksConnectionInterface.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'Gene.filterArtworksConnection'
Input field 'signed' was removed from input object type 'FilterArtworksInput'
Argument 'signed: Boolean' was removed from field 'Tag.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'ArtistSeries.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'Partner.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'Fair.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'MarketingCollection.artworksConnection'
Argument 'signed: Boolean' was removed from field 'Show.filterArtworksConnection'
Argument 'signed: Boolean' was removed from field 'Alert.artworksConnection'
Argument 'signed: Boolean' was removed from field 'Viewer.artworksConnection'
Input field 'updateCollectionInput.name' changed type from 'String' to 'String!'

Generated by 🚫 dangerJS against ba3c53e

@@ -48,6 +48,11 @@ export default (accessToken, _userID, opts) => {
{},
{ method: "POST" }
),
conversationCreateLoader: impulseLoader(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we didn't have this already - we have a bunch of conversation-related mutations in MP already. Are all conversations currently only created via inquiry creation workflow? I see ConversationService#create_conversation code in Gravity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we never exposed anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants