Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[DO-NOT-MERGE]: Update icons to use Artsy Icons #312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Feb 24, 2025

This PR resolves MOPRAT-863

Description

This PR is a follow-up to artsy/icons#58
This PR removes icons that exist in Artsy Icons, and updates the using of these icons to be used from @artsy/icons

@MrSltun MrSltun self-assigned this Feb 24, 2025
@artsy-peril artsy-peril bot added the Version: Minor A deploy for new features label Feb 24, 2025
@artsy-peril
Copy link

artsy-peril bot commented Feb 24, 2025

Fails
🚫

Hi there! 👋

We use conventional commit formatting which has not been detected in your PRs title.

Refer to README#327 and Conventional Commits for PR/commit formatting guidelines.

@artsy/icons

Author: Unknown

Description: [@artsy/icons](https://github.com/artsy/icons) is the canonical source for icons used at Artsy, and serves as an automatic build pipeline for generating JSX representations of `.svg` sources that can easily be imported into React apps.

Homepage: http://npmjs.com/package/@artsy/icons

Createdover 2 years ago
Last Updatedabout 1 hour ago
LicenseMIT
Maintainers6
Releases75
README

@artsy/icons

@artsy/icons is the canonical source for icons used at Artsy, and serves as an automatic build pipeline for generating JSX representations of .svg sources that can easily be imported into React apps.

You can view available icons here and click to copy the import path of the desired icon.

Meta

Build Status

Installation and Usage

yarn add @artsy/icons

And then later, import icons like so:

import ArtsyLogo from "@artsy/icons/ArtsyLogo"

const MyApp = () => {
  return <ArtsyLogo />
}

Alternatively, visit the docs and select individual icons, which will copy the import path to your clipboard.

Adding New Icons

We've setup the repo so that adding new icons and publishing to NPM is as automated as can be:

  1. Clone the repo: git clone https://github.com/artsy/icons.git
  2. Create a new branch: git checkout -b add-new-icon
  3. Copy your new icon .svg file into the src folder (and follow pre-existing naming conventions! 🙏)
  4. Push your branch up to GitHub and open a PR. This should automatically be tagged with a minor label indicating a new feature addition
  5. Merge PR. This will automatically generate JSX components and publish to NPM, and additionally update the docs
  6. Once published, a new comment will be added to the PR announcing the new version.

Development

yarn install
yarn build
yarn docs

New dependencies added: @artsy/icons.

Generated by 🚫 dangerJS against ece4428

@MrSltun MrSltun force-pushed the mrsltun/hack15/use-artsy-icons branch from 2687e32 to b53f89a Compare February 24, 2025 15:57
@MrSltun MrSltun marked this pull request as ready for review February 26, 2025 12:25
@artsy-peril artsy-peril bot added the Jira Synced Indicates that Peril has connected this PR to Jira label Feb 26, 2025
@MrSltun MrSltun changed the title fix: Update icons to use Artsy Icons fix[DO-NOT-MERGE]: Update icons to use Artsy Icons Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant