Skip to content

Conversation

@spywhere
Copy link

@spywhere spywhere commented Feb 12, 2022

Addressed #28 😄


Note

Adds cargo-based source install support (latest/version/commit), updates README with instructions, adjusts tests, and tweaks CI to remove cargo before tests.

  • Install script (bin/install):
    • Add cargo-based source installation via ref:* (supports latest, semver, and full commit SHA) with install_from_source.
    • Retain archive-based installs for release versions via install_from_archive.
    • Validate cargo presence for source builds; error with clear message if missing.
  • Docs (README.md):
    • Document source install flow and dependency on cargo (via asdf-rust).
    • Add examples for ref:<version>, ref:latest, and ref:<full-commit-hash>.
  • Tests (test/install.bats):
    • Update failure expectation to require cargo when using ref.
  • CI (.github/workflows/workflow.yml):
    • Add step to remove preinstalled cargo before tests.

Written by Cursor Bugbot for commit 9abe82e. This will update automatically on new commits. Configure here.

@spywhere spywhere requested a review from a team as a code owner February 12, 2022 10:37
@spywhere
Copy link
Author

@smorimoto sorry for pinging directly but is there anything needed to have this merged?

@smorimoto
Copy link
Member

I will check this tonight.

@spywhere spywhere force-pushed the build-from-source branch from 7ece723 to d10a4d1 Compare March 10, 2022 09:09
@spywhere
Copy link
Author

I'll address comments, hopefully within today

@smorimoto
Copy link
Member

bugbot run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants