Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action_redirect: remove after_bridge_goto_info #1160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

action_redirect: remove after_bridge_goto_info #1160

wants to merge 1 commit into from
+11 −4

Conversation

pjannesen
Copy link
Contributor

@pjannesen pjannesen commented Mar 13, 2025 •
edited by seanbright
Loading

Under certain circumstances the context/extens/prio are stored in the
after_bridge_goto_info. This info is used when the bridge is broken by
for hangup of the other party. In the situation that the bridge is
broken by an AMI Redirect this info is not used but also not removed.
With the result that when the channel is put back in a bridge and the
bridge is broken the execution continues at the wrong
context/extens/prio.

Resolves: #1144

@github-actions GitHub Actions
Copy link

Workflow PRCheck completed successfully

@pjannesen pjannesen mentioned this pull request Mar 13, 2025
Open
1 task
@pjannesen
Copy link
Contributor Author

pjannesen commented Mar 13, 2025 •
edited by jcolp
Loading

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22

@jcolp
Copy link
Member

jcolp commented Mar 13, 2025

18 no longer receives fixes. I have removed it from the cherry pick list.

gtjoseph
gtjoseph requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a "Fixes:" or "Resolves:" trailer to both the PR description and the commit message or the related issue won't automatically close when this PR merges.

See:
https://docs.asterisk.org/Development/Policies-and-Procedures/Commit-Messages/

@pjannesen pjannesen force-pushed the jannesen/fix-action_redirect-bridge_after_goto-master branch from 9d9703d to 3c13dbc Compare March 21, 2025 08:40
@github-actions GitHub Actions
Copy link

Workflow PRCheck completed successfully

@pjannesen pjannesen requested a review from gtjoseph March 21, 2025 18:21
gtjoseph
gtjoseph requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the Resolves trailer to the commit message but not the PR description. It needs to be in the PR description as well or the related issue won't be automatically closed.

@pjannesen pjannesen requested a review from gtjoseph March 27, 2025 20:25
seanbright
seanbright requested changes Apr 8, 2025
View reviewed changes
@pjannesen pjannesen force-pushed the jannesen/fix-action_redirect-bridge_after_goto-master branch from 3c13dbc to d2cdda0 Compare April 9, 2025 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Workflow PRCheck failed
master-ari2: FAILED TEST: rest_api/websocket_requests/bad_requests
master-ari2: FAILED TEST: rest_api/websocket_requests/parallel_requests
master-ari2: FAILED TEST: rest_api/websocket_requests/single_requests

@pjannesen pjannesen force-pushed the jannesen/fix-action_redirect-bridge_after_goto-master branch from d2cdda0 to de729a3 Compare April 9, 2025 15:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Workflow PRCheck failed
master-ari2: FAILED TEST: rest_api/websocket_requests/bad_requests
master-ari2: FAILED TEST: rest_api/websocket_requests/parallel_requests
master-ari2: FAILED TEST: rest_api/websocket_requests/single_requests
master-pjs2: FAILED TEST: channels/pjsip/diversion/diversion_response_drop_options

@pjannesen pjannesen force-pushed the jannesen/fix-action_redirect-bridge_after_goto-master branch from de729a3 to 2a77720 Compare April 9, 2025 15:43
@pjannesen
action_redirect: remove after_bridge_goto_info
b13f3fa 
Under certain circumstances the context/extens/prio are stored in the
after_bridge_goto_info. This info is used when the bridge is broken by
for hangup of the other party. In the situation that the bridge is
broken by an AMI Redirect this info is not used but also not removed.
With the result that when the channel is put back in a bridge and the
bridge is broken the execution continues at the wrong
context/extens/prio.

Resolves: asterisk#1144
@pjannesen pjannesen force-pushed the jannesen/fix-action_redirect-bridge_after_goto-master branch from 2a77720 to b13f3fa Compare April 9, 2025 16:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Workflow PRCheck completed successfully

@pjannesen
Copy link
Contributor Author

Code modified.

PS: This function is not intended for general use but a helper for action_redirect hence the _

@pjannesen pjannesen requested a review from seanbright April 9, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcolp jcolp jcolp approved these changes

@gtjoseph gtjoseph Awaiting requested review from gtjoseph

@seanbright seanbright Awaiting requested review from seanbright

Assignees

@pjannesen pjannesen

Labels
pr-submit-tests-passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: action_redirect don't remove bridge_after_goto data
4 participants
@pjannesen @jcolp @seanbright @gtjoseph