BER-26: [Resources Tab]: Create College Info View #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import SwiftUI | ||
|
|
||
| import SwiftUI |
Collaborator
There was a problem hiding this comment.
Remove duplicate import SwiftUI
Please leave two lines from the import statement to the struct
Comment on lines
43
to
44
| Text("8:30 AM - 12:00 PM").font(Font.custom("BMFont", size:14)) | ||
| Text("1:00 PM - 5:00 PM").font(Font.custom("BMFont", size:14)) |
Collaborator
There was a problem hiding this comment.
For view modifiers, please put them on a new line, indented.
Chhumbucket
requested changes
Feb 28, 2025
Collaborator
Chhumbucket
left a comment
Chhumbucket
left a comment
There was a problem hiding this comment.
Just use ForEach and u can make an array
| } | ||
|
|
||
| private var graduateProgramsView: some View { | ||
| VStack(alignment: .leading) { |
Collaborator
There was a problem hiding this comment.
Instead of manualling making bullet points you should use ForEach to make a list of the degrees in the program do for another other list.
| .underline() | ||
| Text("• Chemistry, Ph.D") | ||
| Text("• Chemical Engineering, Ph.D") | ||
| Text("• Chemical Biology Graduate Program") |
|
|
||
| private var graduateProgramsView: some View { | ||
| VStack(alignment: .leading) { | ||
| Text("Graduate Programs") |
Collaborator
There was a problem hiding this comment.
If the degrees are listed below should those be title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resources Tab]: Create College Info View:
Linear Link: https://linear.app/moon-stone/issue/BER-26/[resources-tab]-create-college-info-view