-
-
Notifications
You must be signed in to change notification settings - Fork 263
feat: validate Avro schemas in AsyncAPI files using CLI #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 984d637 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset has been generated for this PR as part of auto-changeset workflow.Please review the changeset before merging the PR.If you are a maintainer or the author of the PR, you can change the changeset by clicking here Tip If you don't want auto-changeset to run on this PR, you can add the label |
|
|
Hi @Souvikns, Can you please review the pr. |
src/commands/validate.ts
Outdated
| if (schemaFormat?.startsWith('application/vnd.apache.avro')) { | ||
| try { | ||
| avro.Type.forSchema(schema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mime type can also contain the Avro version. Is this not also needed for the validation of Avro?
92ffdfc to
cafcc85
Compare
|
|
@Lazzaretti That file is removed in the latest commit. Made changes and have raised a pr, please review it. |



Description
fixed #1813
installed "avsc": "^5.7.9",
code changes in ./src/commands/validate.ts file