-
-
Notifications
You must be signed in to change notification settings - Fork 264
fix: resolve SonarCloud issues in config and validation services #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: resolve SonarCloud issues in config and validation services #1887
Conversation
🦋 Changeset detectedLatest commit: 6acadf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Changeset has been generated for this PR as part of auto-changeset workflow.Please review the changeset before merging the PR.If you are a maintainer or the author of the PR, you can change the changeset by clicking here Tip If you don't want auto-changeset to run on this PR, you can add the label |
|
|
hey, @Shurtu-gal ill love to contribute more are there some more issues you could provide me to work upon? |
|
You can take a look at #1839 |
|
@Shurtu-gal please take a look here |



This PR resolves multiple SonarCloud code quality issues reported in #1881.
Fixes
src/apps/cli/commands/config/auth/add.ts
src/domains/services/config.service.ts
src/domains/services/validation.service.ts
Testing
Fixes #1881