fix: make startNewVersion script cross-platform (fixes #609)#627
Open
armorbreak001 wants to merge 1 commit into
Open
fix: make startNewVersion script cross-platform (fixes #609)#627armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
The npm script used Unix-specific env var syntax (newVersion=...) which fails on Windows CMD. Fixed by: 1. Script: fallback to process.env.npm_config_new_version 2. Package.json: use node -e wrapper for cross-platform compat Fixes asyncapi#609
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #609
Problem
npm run startNewVersion --newVersion=3.1.0fails on Windows with:Root cause:
newVersion=is Unix shell syntax, incompatible with Windows CMD/PowerShell.Solution
Two-part fix:
process.env.npm_config_new_versionso the script can read the version directly from npm confignode -ewrapper for cross-platform environment variable settingChanges
scripts/add-new-version.js: 1 line changed (fallback)package.json: 1 script updatedTesting