fix: make startNewVersion script cross-platform compatible#630
Open
armorbreak001 wants to merge 1 commit into
Open
fix: make startNewVersion script cross-platform compatible#630armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609
Problem: The
startNewVersionnpm script used Unix shell syntax (newVersion=) which fails on Windows CMD with'newVersion' is not recognized.Changes:
package.json: Removed shell variable assignment, script now just calls node directlyscripts/add-new-version.js: Falls back toprocess.env.npm_config_new_versionwhich npm sets automatically on all platformsBackward compatible: Existing usage
npm run startNewVersion --new-version=2.7.0works unchanged on all platforms (Unix, Windows CMD, PowerShell).Verification: Run
npm run startNewVersion --new-version=3.0.0on both Linux and Windows to confirm it executes without syntax errors.