ci: add build-and-push-sdr workflow triggered by GM release approval#1588
Draft
Lalit3716-atlan wants to merge 4 commits into
Draft
ci: add build-and-push-sdr workflow triggered by GM release approval#1588Lalit3716-atlan wants to merge 4 commits into
Lalit3716-atlan wants to merge 4 commits into
Conversation
Lalit3716-atlan
requested review from
Aryamanz29,
OnkarVO7,
atlan-ci,
cmgrote,
louisnow and
vaibhavatlan
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 79.5%) Detailed Coverage Report |
Contributor
📦 Trivy Vulnerability Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Contributor
📦 Trivy Secret Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/1588 |
…roval Adds a repository_dispatch-triggered workflow (sdr_release_approved) that: 1. Retags the approved GHCR image to <branch>-latest on Docker Hub 2. Dispatches to atlanhq/atlan-apps-deployment to trigger the Helm rollout Global Marketplace fires this dispatch after a channel=all release is approved for an SDR-enabled app, replacing the ungated main-latest push from the build CI.
…-apps-deployment dispatch - Move Docker Hub push out of merge job into a dedicated push-to-dockerhub job that runs after security-scan succeeds — immutable <branch>-<sha7> tag only - Remove app-deployment-dispatcher job: deployment dispatch is now handled by build-and-push-sdr.yml triggered by Global Marketplace on release approval - merge job is now GHCR-only; Docker Hub credentials no longer needed there
…directly to atlan-apps-deployment No longer need to relay through application-sdk to trigger deployment; Global Marketplace fires dispatch_app_builder_workflow directly on approval. Docker Hub main-latest retag is also dropped as no longer required.
Lalit3716-atlan
force-pushed
the
feat/build-and-push-sdr-on-gm-approval
branch
from
a130fe3 to
378766f
Compare
cmgrote
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/build-and-push-sdr.ymltriggered byrepository_dispatcheventsdr_release_approvedchannel=allrelease is approved for an SDR-enabled appmain-<sha>) tomain-lateston Docker Hub, then dispatches toatlanhq/atlan-apps-deploymentto trigger the Helm rolloutDOCKER_HUB_PAT_RWandORG_PAT_GITHUBsecrets — no new secrets needed in this repoWhy this approach
Previously the build CI was pushing
main-lateston every build (ungated). This gates the Docker Hubmain-latesttag behind GM release approval, so only approved releases reach customers pullingmain-latest.Relation to other PRs
sdr_release_approveddispatch from the release approval flowfix/dockerhub-mutable-branch-latest-tag-v2): superseded by this approach — that PR pushedmain-lateston every build without an approval gateTest plan
channel=allrelease in GM for an SDR-enabled appsdr_release_approveddispatch triggers this workflowatlanhq/<repo>:main-latestis updated on Docker Hubatlan-apps-deploymentreceives thedispatch_app_builder_workflowevent