skill: add 'add-sdr-integration-tests' for connector SDR e2e setup#1693
Open
tejeshallampati-alt wants to merge 2 commits into
Open
skill: add 'add-sdr-integration-tests' for connector SDR e2e setup#1693tejeshallampati-alt wants to merge 2 commits into
tejeshallampati-alt wants to merge 2 commits into
Conversation
The shared SDR e2e composite action makes the workflow surface tiny (~50 lines), but the connector-side setup still has half a dozen papercuts that block a first run from going green: app.yaml shape vs atlan.yaml, env-var prefix mismatch breaking framework auto-discovery, local-path vs object-store-key in upload_to_atlan, OAuth client confusion (connector API creds vs Atlan tenant OAuth), and the rest. Documents the recipe alongside the SDK module that ships BaseSDRIntegrationTest. Mirrors the layout of the existing implement-incremental-extraction skill: one SKILL.md plus references/ markdowns for scenario coverage, connector conventions, and a full troubleshooting catalogue derived from the failures seen across mssql, saperp, and looker integrations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tejeshallampati-alt
requested review from
Aryamanz29,
OnkarVO7,
atlan-ci,
cmgrote,
louisnow and
vaibhavatlan
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 77.0%) Detailed Coverage Report |
Contributor
📦 Trivy Vulnerability Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Contributor
📦 Trivy Secret Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/1693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Claude/agent skill that walks through setting up the SDR e2e integration test pipeline on a connector app. Lives under `application_sdk/testing/sdr/skills/` so it ships next to the `BaseSDRIntegrationTest` class it documents, mirroring the layout of the existing `implement-incremental-extraction` skill.
What's included
Why ship as a skill
The composite at `.github/actions/sdr-e2e` makes the connector-side workflow tiny (~50 lines), but the invisible setup (env-var prefix matching app-name, OAuth client distinction, app.yaml shape, upload_to_atlan path-shape) is where every first-run lands. A skill makes the recipe + the troubleshooting concentrated in one place an agent can follow end-to-end.
Test plan
References
🤖 Generated with Claude Code