ci(ae-stack-up): connector deployment=local for dev-vault + create local/dapr#1976
Open
AtMrun wants to merge 5 commits into
Open
ci(ae-stack-up): connector deployment=local for dev-vault + create local/dapr#1976AtMrun wants to merge 5 commits into
AtMrun wants to merge 5 commits into
Conversation
…ocal/dapr - connector worker now runs ATLAN_DEPLOYMENT_NAME=local so /workflows/v1/dev/ local-vault is enabled (was 403); task queue stays atlan-<app>-<deployment> via explicit ATLAN_TASK_QUEUE. - env $extra placed last so per-worker overrides win. - create local/dapr dir so the sqlite statestore can open. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AtMrun
requested review from
Aryamanz29,
OnkarVO7,
atlan-ci,
cmgrote,
louisnow and
vaibhavatlan
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 77.6%) Detailed Coverage Report |
Contributor
📦 Trivy Vulnerability Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Contributor
📦 Trivy Secret Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/1976 |
Collaborator
🧪 Connector Tests — atlan-mysql-appStatus: Passed ✅
|
Collaborator
🧪 Connector Tests — atlan-openapi-appStatus: Passed ✅
|
…neage) Parses SDK-standard log lines (APP_VITALS + shared publish/qi/lineage metrics), so the Fetched/Transformed/Published + QI + Lineage tables render in the Step Summary for any connector — no per-connector parsing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… fail-fast - executor-enabled true so submit actually dispatches the DAG (was leaving every node NOT_STARTED). - replace guessed <guid>-<node> IDs with discovery via temporal workflow list; fail fast in 5 min (dumping real workflow IDs) if nothing dispatches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-status poll - executor-enabled is a publish dry-run flag, not DAG execution; revert to false. - AE names child workflows off an internal GUID, not the submit guid, so stop prefix-guessing: count ALL temporal workflows by status, settle when >=EXPECTED completed and none running. 30-min cap; dump full list on timeout. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rker Without the handler module the connector boots with DefaultHandler (SDR workflows only) and never registers the real extraction workflow, so the AE-dispatched child workflow runs forever. Thread app-module/handler-module through the reusable + action.
cmgrote
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the AE full-DAG local harness so the credential-injection step works.
Bugs (surfaced by the mssql pilot run)
ATLAN_DEPLOYMENT_NAME=ci, but/workflows/v1/dev/local-vaultis only enabled underlocal. Fix: start the connector withATLAN_DEPLOYMENT_NAME=local(queue staysatlan-<app>-<deployment>via explicitATLAN_TASK_QUEUE).unable to open database file) — the./local/dapr/dir didn't exist. Fix:mkdir -p local/daprinwrite_components.env $extramoved last so per-worker overrides actually win.🤖 Generated with Claude Code